⚡ Bolt: Avoid per-frame allocations in KnowledgeGraph - #194
servathadi wants to merge 1 commit into
Conversation
Moved the `new Map()` instantiation out of the `simulate` requestAnimationFrame loop and cached it using `useRef` to eliminate per-frame garbage collection pauses during force-directed graph rendering. Co-authored-by: servathadi <116760885+servathadi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
💡 What: Moved the
nodeMapinstantiation out of thesimulatehot loop and cached it in auseRefupdated viauseEffect.🎯 Why: In React requestAnimationFrame canvas renders, per-frame memory allocations (such as
new Map()) cause significant garbage collection pauses.📊 Impact: Reduces garbage collection pressure during graph simulation, leading to smoother animations.
🔬 Measurement: Verify smoother frame rates without intermittent GC spikes during graph visualization.
PR created automatically by Jules for task 16607051373886487786 started by @servathadi