fix: resolve UBSAN and ASAN reported undefined behavior and bugs - #927
Merged
Conversation
Akilan-Sivakumar
commented
Jul 24, 2026
Akilan-Sivakumar
commented
Collaborator
- Fixed signed left-shift undefined behavior reported by UBSAN.
- Replaced unsafe function-pointer casts in the HIGH_BIT_DEPTH primitive aliasing with safe trampolines that only reinterpret data pointers.
- Added guards for out-of-bounds access, division-by-zero, and uninitialized/stale reads flagged by ASAN.
- Fixed a TestBench segfault at high bit depth caused by the new alias trampolines.
Akilan-Sivakumar
force-pushed
the
asan_ubsan
branch
from
July 28, 2026 12:49
447112c to
29d78b3
Compare
Akilan-Sivakumar
force-pushed
the
asan_ubsan
branch
from
July 28, 2026 12:56
29d78b3 to
39538a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.