Skip to content

Fix CI: macOS deserializer compile failure and Windows CMD infinite recursion#2

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fix-ci-issues
Draft

Fix CI: macOS deserializer compile failure and Windows CMD infinite recursion#2
Copilot wants to merge 2 commits intomainfrom
copilot/fix-ci-issues

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 21, 2026

Two independent CI failures preventing the build-v8dasm workflow from completing on both platforms.

macOS ARM64 — deserializer.cc compile error

Cause: \s* prefix in the semantic patch regex consumed the preceding newline, collapsing #endif // DEBUG and } onto one line. The } became part of the // DEBUG comment, leaving the constructor unclosed and producing 12+ cascading errors.

# Before — \s* eats the newline before CHECK_EQ, joining it with the #endif line
pattern = r'\s*CHECK_EQ\s*\(\s*magic_number_\s*,\s*SerializedData::kMagicNumber\s*\)\s*;?\s*\n?'
# Result: "#endif  // DEBUG}" — '}' is inside the comment, constructor never closed

# After — [ \t]* matches only horizontal whitespace, preserves line boundaries
pattern = r'[ \t]*CHECK_EQ\s*\(\s*magic_number_\s*,\s*SerializedData::kMagicNumber\s*\)[^\n]*\n'
# Result: "#endif  // DEBUG\n}\n" — correct

Windows x64 — exit code 255

Cause: apply-patch.cmd used call :reset_to_clean_state as a subroutine but the label had no goto :eof terminator. Execution fell through into every subsequent label, recursing back into :reset_to_clean_state until CMD's call stack overflowed. Each iteration was near-instant (git failing immediately), so the whole crash happened in ~100ms.

Changes to apply-patch.cmd:

  • Restructured into proper CMD subroutines — each function ends with goto :eof, main flow uses explicit call :fn + if %errorlevel% equ 0 exit /b 0 chain
  • Added chcp 65001 at startup for UTF-8 support (emoji in echo without this could also cause abnormal termination)
  • Added git config --global --add safe.directory for the V8 repo to prevent git ownership errors
  • Removed emoji characters (, ) from echo statements to eliminate encoding fragility

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • chromium.googlesource.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

帮我看看ci出什么问题了


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…cursion (Windows)

Co-authored-by: MrSibe <136715923+MrSibe@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MrSibe/AutoView8/sessions/080b32c6-75cb-454c-a0ec-7129790ef5b1
Copilot AI changed the title [WIP] Fix issues in CI configuration Fix CI: macOS deserializer compile failure and Windows CMD infinite recursion Mar 21, 2026
Copilot AI requested a review from MrSibe March 21, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants