Repository navigation
Drop the Makefile's old XDK source tree paths - #98
Merged
Merged
Conversation
Nothing used them; the Xbox build reads only your XDK's include and lib through Makefile.xbox. Fixed the comments that still asked for a source tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop Makefile still defined XDK_BASE and six paths into an XDK source tree (private/inc, private/ntos, public/sdk and so on) that nothing used. The Xbox build goes through Makefile.xbox and only reads your own XDK's include and lib folders. Removed the dead paths and fixed the comments that still asked for a source tree. Lint, desktop, Xbox retail and debug all build clean.