Repository navigation
Own names for the rebuilt engine's internals - #97
Merged
Merged
Conversation
The app class at 0x0017e7a0 never had a name in the binary, so I picked CAppShell and used it in the docs and comments. Its frame loop is AppShell_Run and the alloc and sound buffer helpers follow the same prefix.
Renamed the bound pad pointers, the button combo state and the remote timers in the Xbox and desktop input code. Nothing script visible changed, and the compiled code is byte for byte the same.
The device slot defines are SLOT_P1A through SLOT_P4B plus SLOT_HDD now, and the memory monitor, disc type and CD-ROM service members got names of their own. Compiled code is unchanged.
Runner, compiler, array and class record members and globals got names of their own. Only CHECK message text changes in the compiled code; the PRD and FND table names stay as they are.
The view and camera matrices, level and tunnel pointers, fade and lerp endpoints, bounds, clip rects and the background loader tick have names of their own now. Compiled code is unchanged.
Material colors, palette blending, the audio visualizer buffers, the image cache, the text edit cursor and the current language and region globals got names of their own. Compiled code is unchanged.
The play state defines, the audio and screen change trackers, the screen saver pointer, the settings file member and the alloc retry counter got names of their own. Compiled code is unchanged.
The image fader's warp field and the 8 bit surface still used the old mName style members, so I gave them names in our own style. Compiled code is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every engine body is now rebuilt from the 5960 retail dashboard, so the names for things the binary doesn't name are ours to pick. This gives the app shell, input, memory unit slots, disc state, script engine internals, scene and level state, materials, text, audio and the warp field their own names, and calls the binary's app class CAppShell throughout the code and docs/decomp. Nothing scripts or XIPs see changed: property and function tables, event names and node names stay as they are.
Renames only. After every group the compiled code was identical: all 99 desktop objects kept byte identical code (three CHECK message strings changed with the member they print), all 72 Xbox objects kept identical code, and every smoke run was clean.