Repository navigation
Xbox engine files rebuilt from the 5960 binary - #95
Merged
Merged
Conversation
Rewrote CTitleArray from the 5960 title collection code and folded the desktop copy of its header into the shared one. An old vs new harness over 400 generated memory unit and hard drive layouts printed the same 218,941 lines.
Rewrote CGameCopier, CopyDestination, File and Folder from the 5960 code. A harness copying generated saves between a fake hard drive and memory unit, with failures thrown in, plus the destination picker and folder listing, printed the same 217,258 lines old and new over 500 runs.
Rewrote AudioClip, PeriodicAudioGroup and the buffer and stream classes from the 5960 code. The MP3 pump is Theseus's own and stays as it was. A harness driving clips through random property changes, wave files good and broken, and the stream thread printed the same 140,755 lines old and new over 500 runs. Needs a console run.
A save copy no longer fails just because the title's meta file didn't copy, a folder is made writable before it's removed, and a title size cut short by cancel gets counted again instead of being cached wrong. All three are what 5960 does. Needs a console test.
Rewrote SavedGameGrid's list, layout, selection, sizing, copy and delete code from the 5960 code. The DLC items, ContentMeta reader and Live account calls are Theseus's and stay as they were. A harness driving random devices, titles and saves through selection, scrolling, rendering, copy and delete printed the same 630,872 lines old and new over 400 runs.
GetSavedGameCount stored the -1 a cancelled scan returns and then did new CSave[-1]. Now a cancelled title stays unscanned and reads as no saves until the next scan. Nothing passes a cancel event today, so it was latent. Needs a console test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared engine files the Xbox build uses, rebuilt from the 5960 retail dashboard: the title list, the save copier and file nodes, the audio clip and sound buffers, and the saved game grid. Each rebuilt function carries the binary address it came from, with write-ups in docs/decomp (TitleCollection, FileOps, AudioSystem, SavedGameGrid). The desktop copy of the title list header folded into the shared one. Theseus's own parts (the MP3 pump, the MP3 folder scan, DLC items, ContentMeta reading, Live account selection) are kept as they were.
Checked old against new with the logic running on fake devices, titles and files: 400 title list runs (218,941 lines), 500 file op runs (217,258), 500 audio runs (140,755) and 400 save grid runs (630,872), all identical. Xbox retail and debug compile clean, desktop builds and runs clean.
Fixes, each in its own commit and needing a console test: