BACK-476 - Fix-inline-code-HTML-escaping-in-markdown-renderer#650
Open
kuwork wants to merge 4 commits into
Open
BACK-476 - Fix-inline-code-HTML-escaping-in-markdown-renderer#650kuwork wants to merge 4 commits into
kuwork wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes double HTML-entity encoding inside inline code and fenced code blocks across all views that use the
MermaidMarkdownrenderer (wiki, task details, documentation, decisions, and file previews).The
sanitizeMarkdownSourcehelper was escaping<to<indiscriminately across the entire markdown source. Because code regions are already rendered verbatim by the Markdown engine, this caused users to see<id>instead of<id>inside inline code like`<id>`.The fix collects protected ranges for fenced code blocks and inline code spans before running the
<escape replacement, skipping any match that falls inside a code region.Related Tasks
closes BACK-476Task Checklist
backlog/tasks/Testing
bunx tsc --noEmitpasses with no new errors.<(e.g.`backlog task <id>`) now renders as<id>instead of<id>on wiki pages.<are also preserved correctly.<Something>escaped to prevent accidental HTML tag parsing.<mailto:...>) and email autolinks continue to work.