Skip to content

chore: update to TeraNUI 3.0 from 1.5, for gestalt separation#4598

Merged
keturn merged 10 commits into
developfrom
nui-gestalt-separation
Apr 2, 2021
Merged

chore: update to TeraNUI 3.0 from 1.5, for gestalt separation#4598
keturn merged 10 commits into
developfrom
nui-gestalt-separation

Conversation

@keturn
Copy link
Copy Markdown
Member

@keturn keturn commented Mar 23, 2021

This updates Terasology for MovingBlocks/TeraNUI#47

Making less of NUI depend on a specific version of gestalt, which will make our gestalt upgrade easier.

Based on https://github.com/BenjaminAmos/Terasology/tree/nui-gestalt-separation
I hope @BenjaminAmos will forgive me for making a PR of it.

How to test

Brief description of how to test / confirm this PR before merging

Outstanding before merging

If anything. You can use neat checkboxes! Feel free to delete if not needed

  • Need to consider use case x
  • Still have to adjust the wiki doc

Also updated nui-reflect ClassMetadata#getUri() calls to ClassMetadata.getId().
@keturn keturn added the Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. label Mar 23, 2021
@keturn keturn added this to the v4.4.0 milestone Mar 23, 2021
The gestalt-separation branch of NUI.
@keturn keturn force-pushed the nui-gestalt-separation branch from 2272a25 to 13758b3 Compare March 23, 2021 23:25
Copy link
Copy Markdown
Member Author

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing out well so far

keturn added a commit to Terasology/WorldlyTooltip that referenced this pull request Mar 24, 2021
@keturn keturn changed the title chore: update TeraNUI to 3.0 from 1.5, for gestalt separation chore: update to TeraNUI 3.0 from 1.5, for gestalt separation Mar 25, 2021
skaldarnar pushed a commit to Terasology/WorldlyTooltip that referenced this pull request Mar 27, 2021
@keturn keturn marked this pull request as ready for review April 2, 2021 02:51
Copy link
Copy Markdown
Contributor

@DarkWeird DarkWeird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.
Works all basic screens works in main menu, also works controls.

Not works loading/creating world(not found world generator) - i think that because i have dirty omega workspace

@keturn
Copy link
Copy Markdown
Member Author

keturn commented Apr 2, 2021

I ran omega tests and they are mostly good, except some NameGenerator tests that CI says weren't failing in the last build.

org.terasology.namegenerator.CreatureNameProviderTest

java.lang.ExceptionInInitializerError
	at org.terasology.namegenerator.creature.CreatureNameProvider.<init>(CreatureNameProvider.java:46)
	at org.terasology.namegenerator.CreatureNameProviderTest.testBase(CreatureNameProviderTest.java:47)
Caused by: java.util.NoSuchElementException: No value present
	at java.base/java.util.Optional.get(Optional.java:148)
	at org.terasology.namegenerator.creature.CreatureAssetTheme.fetchNameList(CreatureAssetTheme.java:94)
	at org.terasology.namegenerator.creature.CreatureAssetTheme.<init>(CreatureAssetTheme.java:65)
	at org.terasology.namegenerator.creature.CreatureAssetTheme.<clinit>(CreatureAssetTheme.java:34)
	... 93 more

and this is one of those things where it's hard to imagine it being NUI-related.

It might be a CI vs local thing instead? should test develop locally to confirm.

@keturn keturn merged commit 0d8be7e into develop Apr 2, 2021
@keturn keturn deleted the nui-gestalt-separation branch April 2, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants