chore: update to TeraNUI 3.0 from 1.5, for gestalt separation#4598
Merged
Conversation
Also updated nui-reflect ClassMetadata#getUri() calls to ClassMetadata.getId().
The gestalt-separation branch of NUI.
2272a25 to
13758b3
Compare
keturn
commented
Mar 24, 2021
Member
Author
keturn
left a comment
There was a problem hiding this comment.
testing out well so far
keturn
added a commit
to Terasology/WorldlyTooltip
that referenced
this pull request
Mar 24, 2021
skaldarnar
pushed a commit
to Terasology/WorldlyTooltip
that referenced
this pull request
Mar 27, 2021
…SkinTypeHandler-subclassing TeraNUI 3.0 update: Implemented `UISkinTypeHandler.getAsString`
DarkWeird
approved these changes
Apr 2, 2021
Contributor
DarkWeird
left a comment
There was a problem hiding this comment.
Looks good for me.
Works all basic screens works in main menu, also works controls.
Not works loading/creating world(not found world generator) - i think that because i have dirty omega workspace
Member
Author
|
I ran omega tests and they are mostly good, except some NameGenerator tests that CI says weren't failing in the last build. org.terasology.namegenerator.CreatureNameProviderTest and this is one of those things where it's hard to imagine it being NUI-related. It might be a CI vs local thing instead? should test develop locally to confirm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates Terasology for MovingBlocks/TeraNUI#47
Making less of NUI depend on a specific version of gestalt, which will make our gestalt upgrade easier.
Based on https://github.com/BenjaminAmos/Terasology/tree/nui-gestalt-separation
I hope @BenjaminAmos will forgive me for making a PR of it.
How to test
Brief description of how to test / confirm this PR before merging
Outstanding before merging
If anything. You can use neat checkboxes! Feel free to delete if not needed