feat: migrate in change from v1 to master#46
Closed
pollend wants to merge 9 commits into
Closed
Conversation
* Converted NUI to use gestalt 7.0.3 * Updated library version to 2.0.0 due to gestalt upgrade (now using gestalt 7) * Fixed compiler errors due to changed gestalt namespace * Added google maven repository.
This is required to ensure that RectUtility for Rectanglef works the same way as for Rectanglei.
On TeraMath classes `Rect2i` and `Rect2f` had the semantics that creating them from min and size would validate that the size is positive along both axis. The JOML utility class was missing this feature. This also adds overflow prevention.
Adds JavaDoc to explain what the methods are doing and to state contracts and guarantees.
skaldarnar
reviewed
Mar 21, 2021
Member
skaldarnar
left a comment
skaldarnar
left a comment
There was a problem hiding this comment.
The following commits were already cherry-picked to the v2 main line:
- 24902bc chore: add info how to get TeraNUI for local testting (as 40b4a18)
- 9c88213 chore: Add math utility
addClampAtMaxfor float (as b228db2) - 35b38ab fix:
createFromMinAndSizeclamps and validates result (as a4a74e3) - 77fc889 docs: Add JavaDoc for
createFromMinAndMax(as e1f7918)
8bfd1db fiy(miglayout): setRowConstraints uses col constraints (#25) was submitted as separate PR agains v2 main line branch as 7e9c5d5 fiy(miglayout): setRowConstraints uses col constraints (#26).
- at the time we merged 6abc996 from PR #12 I wasn't sure whether it is fully compatible the way it is with gestalt v7. I still don't know, so I hope you (@pollend, @DarkWeird) can judge that better
- PR #24 feat(lwjgl3): split keyboard input to raw input and text input. Returns MouseDevice#getPosition was merged in 7f66723 and does quite a few things on the LWJGL3 front
@DarkWeird can you confirm this is also safe for gestalt v7? - PR #36 feat(flexibleconfig): UI for editing arbitrary types and AutoConfigs was merged in
6a27464 adding the auto config bits. This uses reflection.
@pollend, @DarkWeird Does this interfere with gestalt v7 in any way?
Member
Author
|
If they were cherry picked then those commits have separate ids so they would essentially appear twice in the history. This is just a direct merge from v1 to master. |
5 tasks
keturn
force-pushed
the
master
branch
2 times, most recently
from
989bc52 to
f6e444f
Compare
Member
|
With #47 merged, this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt to bring all the v1 fixes to the v2 main line.
Contributes to #43