ci: run R tests on master branch and skip docs-only changes - #356
Merged
Conversation
The R-tests workflow only triggered on develop, but the GitHub default branch is master and PRs merge directly into master, so most PRs ran no tests. Add master to push/pull_request triggers, and add paths-ignore for docs/markdown so the 8-job matrix doesn't run on pure doc changes. Also correct AGENTS.md, which incorrectly stated the default branch is develop.
gdevenyi
force-pushed
the
ci/test-triggers-master-develop
branch
from
July 8, 2026 19:32
b3e6a21 to
e8c5844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The
R-testsworkflow only triggered ondevelop, but the GitHub default branch ismasterand PRs merge directly intomaster(e.g. #346–#354, including code fixes likefix/bind1st-cpp17#351). As a result, most PRs ran zero tests. AGENTS.md also incorrectly claimed the default branch wasdevelop, which is why this went unnoticed.Changes
.github/workflows/R-tests.yml— addedmasterto bothpush.branchesandpull_request.branches; addedpaths-ignorefordocs/**,**/*.md,**/README*, andpkgdown.yamlso pure docs/markdown changes skip the 8-job matrix (2 OS × 4 R versions).man/**,NAMESPACE,DESCRIPTION,src/**,R/**stay covered soR CMD checkstill validates them.AGENTS.md— fixed the Conventions line to reflect reality.pkgdown.yamlis intentionally untouched (its triggers are already correct, and skipping PRs there is by design since it commits to the repo).Verification
python3 -c 'yaml.safe_load(...)'✅Notes
paths-ignoreoperates per-push, so a PR mixing code + docs still runs tests; only docs-only commits skip. This is standard GitHub behavior.masterPRs for the first time.