fix: add missing wait and ignore_incompletes parameters to pMincApply and qMincApply - #355
Conversation
|
Can you describe the bug you discovered which requires this fix? |
There was a problem hiding this comment.
Pull request overview
This PR fixes argument passthrough in RMINC’s parallel apply wrappers so that wait and ignore_incompletes are handled by the batching/reduction pipeline (rather than falling through into the user’s voxel function and causing unused argument runtime errors).
Changes:
- Adds
wait(defaultTRUE) topMincApply()and passes it through toqMincApply(). - Adds
ignore_incompletes(defaultFALSE) topMincApply()andqMincApply(), passing it through toqMincReduce().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gdevenyi
left a comment
There was a problem hiding this comment.
Summary
The fix is correct in intent — thanks. wait and ignore_incompletes were being captured by ... and bound to the user's voxel function, which is the source of the unused argument errors. Promoting them to named params and threading them through to qMincReduce is the right fix. As a bonus it also resolves a pre-existing doc/signature mismatch — both params were already documented in the qMincApply roxygen block.
Requesting changes for formatting only (tabs vs spaces + trailing whitespace). See inline notes.
Verified
ignore_incompletesis a valid arg ofqMincReduce(R/minc_parallel.R:569).waitis already an arg ofqMincApply(R/minc_parallel.R:414).pMincApplyinherits both param docs via@inheritParams qMincApply(R/minc_parallel.R:105), so no roxygen regeneration is strictly required.
Worth considering (non-blocking)
The local = TRUE branch calls mcMincApply (R/minc_parallel.R:160) without wait/ignore_incompletes. Now that they're named params they're silently dropped for local jobs. Probably fine since local is synchronous, but a one-line note in the details block would help users avoid surprises.
|
Can you please also rebase this PR against develop so we can stage changes for a new release there |
… and qMincApply - Add wait parameter to pMincApply signature (default TRUE) and pass through to qMincApply - Add ignore_incompletes parameter to pMincApply and qMincApply signatures (default FALSE) and pass through to qMincReduce Without these fixes, wait and ignore_incompletes fall through ... into the user's voxel function causing 'unused argument' errors at runtime.
removing trailing white space according to copilot's suggestion Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
c1744db to
947eb3f
Compare
|
Thanks for your contribution! |
Without these fixes, wait and ignore_incompletes fall through into the user's voxel function causing 'unused argument' errors at runtime.