fix(deploy): use pnpm legacy deploy mode (#197) - #198
Conversation
Confidence Score: 4/5Safe to merge — the change is a one-line targeted fix that uses a documented pnpm v10 flag to unblock the deploy step. The Files Needing Attention: No files require special attention. The single changed line in Reviews (1): Last reviewed commit: "fix(deploy): use pnpm legacy deploy mode..." | Re-trigger Greptile |
| # pnpm deploy bundles the server with only its production node_modules, | ||
| # its built dist/, and its built public/ at the bundle root. | ||
| RUN pnpm --filter use-case-library-server deploy --prod /app/bundle | ||
| RUN pnpm --filter use-case-library-server deploy --prod --legacy /app/bundle |
There was a problem hiding this comment.
Consider migrating to
inject-workspace-packages for future pnpm compatibility
The --legacy flag is the correct workaround for pnpm v10's new requirement that workspaces set inject-workspace-packages=true before pnpm deploy will work without it. It is documented and valid in 10.x. However, pnpm maintainers have flagged legacy deploy mode as a candidate for removal in v11 (see pnpm/pnpm#9335). The forward-compatible path is to add inject-workspace-packages=true to the workspace root .npmrc, which enables the new lockfile-based deploy and removes the need for --legacy. No urgency while pinned to 10.34.5, but worth tracking before the next pnpm major upgrade.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
No description provided.