Skip to content

fix(deploy): use pnpm legacy deploy mode (#197) - #198

Merged
Giselle Rogers (gbrogers) merged 1 commit into
mainfrom
staging
Aug 3, 2026
Merged

fix(deploy): use pnpm legacy deploy mode (#197)#198
Giselle Rogers (gbrogers) merged 1 commit into
mainfrom
staging

Conversation

@gbrogers

Copy link
Copy Markdown
Contributor

No description provided.

@gbrogers
Giselle Rogers (gbrogers) requested a review from a team August 3, 2026 18:55
@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown

Confidence Score: 4/5

Safe to merge — the change is a one-line targeted fix that uses a documented pnpm v10 flag to unblock the deploy step.

The --legacy flag is valid and documented in pnpm 10.x, and the pinned version (10.34.5) is well past the point where early --legacy bugs (symlinks instead of copies, missing workspace packages) were fixed. The only note is that pnpm's maintainers have signalled intent to drop legacy deploy mode in v11, so this flag will need to be revisited on the next pnpm major upgrade.

Files Needing Attention: No files require special attention. The single changed line in use-case-library-site/Dockerfile is correct for the current pnpm version.

Reviews (1): Last reviewed commit: "fix(deploy): use pnpm legacy deploy mode..." | Re-trigger Greptile

# pnpm deploy bundles the server with only its production node_modules,
# its built dist/, and its built public/ at the bundle root.
RUN pnpm --filter use-case-library-server deploy --prod /app/bundle
RUN pnpm --filter use-case-library-server deploy --prod --legacy /app/bundle

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Consider migrating to inject-workspace-packages for future pnpm compatibility

The --legacy flag is the correct workaround for pnpm v10's new requirement that workspaces set inject-workspace-packages=true before pnpm deploy will work without it. It is documented and valid in 10.x. However, pnpm maintainers have flagged legacy deploy mode as a candidate for removal in v11 (see pnpm/pnpm#9335). The forward-compatible path is to add inject-workspace-packages=true to the workspace root .npmrc, which enables the new lockfile-based deploy and removes the need for --legacy. No urgency while pinned to 10.34.5, but worth tracking before the next pnpm major upgrade.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@gbrogers
Giselle Rogers (gbrogers) merged commit 94e8e10 into main Aug 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant