Skip to content

feat(aligned-onboarding): seed report dashboard setup - #148

Open
ioana (ioanahayman) wants to merge 10 commits into
stagingfrom
codex/account-setup-package
Open

feat(aligned-onboarding): seed report dashboard setup#148
ioana (ioanahayman) wants to merge 10 commits into
stagingfrom
codex/account-setup-package

Conversation

@ioanahayman

@ioanahayman ioana (ioanahayman) commented Jun 30, 2026

Copy link
Copy Markdown

Summary

  • Registers Aligned Onboarding as the manual package-index package for the package-manager surface.
  • Adds the package-manager manifest for Aligned Onboarding, including skill and Brain resources installed under /agent/.agents/skills/aligned-onboarding/ and /agent/brain/aligned-onboarding/.
  • Adds Report Dashboard Setup as the customer-owned reporting/app companion to Account Context Brain. It captures standard views, saved-report trust, source-of-truth rules, metric labels/order, thresholds, date windows, taxonomy, creative evidence, visual/delivery standards, delivery cadence, validation surface, generated-app quality floor, and reusable component-role handoff in /agent/brain/meta/report-dashboard-context.md.
  • Separates VM/customer-specific report app setup from core agent-builder and design-system behavior: customers can tune saved-report trust, idiosyncratic labels, preferred views, caveats, media rules, and app-quality expectations without editing standard prompt or component contracts.
  • Records component handoff in customer-visible business roles such as report shell, KPI band, creative cards, comparison table, chart, filters, detail view, and caveats. Agent Builder maps those roles onto the active generated-app scaffold and Roberto's reusable component layer when building the surface.
  • Aligns the Account Context Brain, Report Dashboard Setup, Creative Corpus, and Motion CLI guide around the intended precedence: account interpretation in account-context.md, report/app packaging in report-dashboard-context.md, and creative evidence in the corpus.
  • Keeps package-facing language on default Brain retrieval and customer-visible reporting surfaces, while treating corpus-search as an optional technical supplement for deliberate filterable search.
  • Extends package-index validation so indexed packages are checked against package-local manifests, install policy stays aligned with the index, duplicate resource ids are rejected, and PR-mode fleet-impact checks fetch the base index before comparing managed-sync package changes.

Functionality Preservation

  • Package-owned setup docs install under /agent/brain/aligned-onboarding/; generated customer-owned setup stays visible and editable under /agent/brain/meta/.
  • Account Context Brain remains the sole source for how the account is interpreted; Report Dashboard Setup controls report/app/dashboard packaging; Creative Corpus supplies stable creative evidence.
  • Starter views, date windows, media treatment, quality-floor rules, and validation surfaces stay confirmable rather than stored as customer truth until the team or a trusted saved report proves them.
  • The app quality floor treats overflowed labels, unreadable media overlays, unlabeled blank media, raw fallback metric names, inconsistent creative cards, hidden data caveats, and untested narrow widths as setup failures for generated report/app surfaces.
  • The customer setup stores component roles and quality expectations, not internal tag names; generated-app prompts and the active design-system scaffold own the exact component implementation.
  • The package remains manual and uninstallable, with no auto fleet rollout.

Validation

  • node --test scripts/validate-runneth-package-index.mjs
  • GITHUB_EVENT_NAME=pull_request GITHUB_BASE_REF=staging node --test scripts/validate-runneth-package-index.mjs
  • node -e 'for (const file of ["package-index.json","aligned-onboarding/package.json","aligned-onboarding/install-config.json","aligned-onboarding/use-case.json","creative-strategy-foundations/package.json"]) JSON.parse(require("fs").readFileSync(file,"utf8"));'
  • git diff --check HEAD~3..HEAD
  • git merge-tree --write-tree HEAD origin/staging

@ioanahayman
ioana (ioanahayman) marked this pull request as ready for review June 30, 2026 15:27
@ioanahayman
ioana (ioanahayman) requested a review from a team June 30, 2026 15:27
…p-package

# Conflicts:
#	aligned-onboarding/README.md
#	aligned-onboarding/SKILL.md
#	aligned-onboarding/account-context-brain.md
#	aligned-onboarding/creative-corpus-playbook.md
#	aligned-onboarding/install-config.json
#	aligned-onboarding/marketing.md
#	aligned-onboarding/motion-cli-data-query-guide.md
#	aligned-onboarding/use-case.json
@ioanahayman
ioana (ioanahayman) changed the base branch from main to staging July 25, 2026 02:57
@ioanahayman ioana (ioanahayman) changed the title feat(account-setup): add visible account setup package feat(aligned-onboarding): seed report dashboard setup Jul 25, 2026
@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

Confidence Score: 4/5

Safe to merge for content changes; one validator edge case and one documentation inconsistency warrant fixes before the next time someone targets a branch that lacks the index file.

The validation script's refactored readBaseIndex removes the error handler that returned null when git show exits with code 128. If a PR targets a branch that predates package-index.json, the validation run crashes with an unhandled exception rather than degrading gracefully. Separately, the motion-cli-data-query-guide.md new section hardcodes the default output path while all peer files use resolved placeholders, which would cause writes to the wrong file in workspaces with custom-indexed reporting paths.

Files Needing Attention: scripts/validate-runneth-package-index.mjs and aligned-onboarding/motion-cli-data-query-guide.md

Comments Outside Diff (1)

  1. scripts/validate-runneth-package-index.mjs, line 294-319 (link)

    P1 Removed error handler leaves git show failures unhandled

    The old code wrapped git show in a try/catch that returned null when the exit code was 128 — covering the case where package-index.json doesn't yet exist at the base ref. The new code removes that catch entirely. If git fetch succeeds but git show still fails (e.g. the index file is absent from the fetched ref, or a transient git show error surfaces after the fetch), the function throws an uncaught exception and crashes the entire validation run rather than returning null and letting the fleet-impact checks degrade gracefully.

    The fix is to keep a try/catch around the git show call and return null on exit code 128, as before.

Reviews (2): Last reviewed commit: "fix(package-index): fetch base before fl..." | Re-trigger Greptile

Comment on lines 189 to +198
- `motion meta competitor-ad-insights --ad-library-creative-id <id>` — one Meta ad-library competitor creative
- `motion analyze-media --filename <f>` / `--folder <dir>` — analyze uploaded video (last resort vs `--include-transcript`)

### Saved reports in Report Dashboard Setup

Use `motion reports` and `motion reports --report-id <id>` to inspect saved report configuration
for customer-named dashboards. Record the report title, purpose, platform, date behavior, metric
basis, grouping, and visible report ID or URL in `/agent/brain/meta/report-dashboard-context.md`
only when the customer says that report is a trusted starting point. Saved report metadata can guide
view shape; it does not override current-turn instructions or the customer's report-dashboard setup.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Hardcoded path contradicts the PR's dynamic-path design

This new section instructs the agent to record saved-report metadata to the literal path /agent/brain/meta/report-dashboard-context.md. But the rest of this PR explicitly designs all three companion files (account-context-brain.md, creative-corpus-playbook.md, report-dashboard-setup.md) to resolve the write target from an established indexed location first, falling back to the package default only when none exists. If a workspace has its reporting/app setup file at a custom-indexed path, an agent following this guide will write to the wrong file while every other step in the package correctly resolves the path. The section should use "the workspace's established reporting/app setup file" (or the <reportingSetupPath> placeholder used elsewhere) instead of the hardcoded default.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant