feat(aligned-onboarding): seed report dashboard setup - #148
feat(aligned-onboarding): seed report dashboard setup#148ioana (ioanahayman) wants to merge 10 commits into
Conversation
…p-package # Conflicts: # aligned-onboarding/README.md # aligned-onboarding/SKILL.md # aligned-onboarding/account-context-brain.md # aligned-onboarding/creative-corpus-playbook.md # aligned-onboarding/install-config.json # aligned-onboarding/marketing.md # aligned-onboarding/motion-cli-data-query-guide.md # aligned-onboarding/use-case.json
…p-package # Conflicts: # package-index.json # scripts/validate-runneth-package-index.mjs
Confidence Score: 4/5Safe to merge for content changes; one validator edge case and one documentation inconsistency warrant fixes before the next time someone targets a branch that lacks the index file. The validation script's refactored readBaseIndex removes the error handler that returned null when git show exits with code 128. If a PR targets a branch that predates package-index.json, the validation run crashes with an unhandled exception rather than degrading gracefully. Separately, the motion-cli-data-query-guide.md new section hardcodes the default output path while all peer files use resolved placeholders, which would cause writes to the wrong file in workspaces with custom-indexed reporting paths. Files Needing Attention: scripts/validate-runneth-package-index.mjs and aligned-onboarding/motion-cli-data-query-guide.md
|
| - `motion meta competitor-ad-insights --ad-library-creative-id <id>` — one Meta ad-library competitor creative | ||
| - `motion analyze-media --filename <f>` / `--folder <dir>` — analyze uploaded video (last resort vs `--include-transcript`) | ||
|
|
||
| ### Saved reports in Report Dashboard Setup | ||
|
|
||
| Use `motion reports` and `motion reports --report-id <id>` to inspect saved report configuration | ||
| for customer-named dashboards. Record the report title, purpose, platform, date behavior, metric | ||
| basis, grouping, and visible report ID or URL in `/agent/brain/meta/report-dashboard-context.md` | ||
| only when the customer says that report is a trusted starting point. Saved report metadata can guide | ||
| view shape; it does not override current-turn instructions or the customer's report-dashboard setup. |
There was a problem hiding this comment.
Hardcoded path contradicts the PR's dynamic-path design
This new section instructs the agent to record saved-report metadata to the literal path /agent/brain/meta/report-dashboard-context.md. But the rest of this PR explicitly designs all three companion files (account-context-brain.md, creative-corpus-playbook.md, report-dashboard-setup.md) to resolve the write target from an established indexed location first, falling back to the package default only when none exists. If a workspace has its reporting/app setup file at a custom-indexed path, an agent following this guide will write to the wrong file while every other step in the package correctly resolves the path. The section should use "the workspace's established reporting/app setup file" (or the <reportingSetupPath> placeholder used elsewhere) instead of the hardcoded default.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
/agent/.agents/skills/aligned-onboarding/and/agent/brain/aligned-onboarding/./agent/brain/meta/report-dashboard-context.md.account-context.md, report/app packaging inreport-dashboard-context.md, and creative evidence in the corpus.Functionality Preservation
/agent/brain/aligned-onboarding/; generated customer-owned setup stays visible and editable under/agent/brain/meta/.Validation
node --test scripts/validate-runneth-package-index.mjsGITHUB_EVENT_NAME=pull_request GITHUB_BASE_REF=staging node --test scripts/validate-runneth-package-index.mjsnode -e 'for (const file of ["package-index.json","aligned-onboarding/package.json","aligned-onboarding/install-config.json","aligned-onboarding/use-case.json","creative-strategy-foundations/package.json"]) JSON.parse(require("fs").readFileSync(file,"utf8"));'git diff --check HEAD~3..HEADgit merge-tree --write-tree HEAD origin/staging