Brain submissions: label zip downloads with the customer name - #147
Open
rezakhadjavi wants to merge 1 commit into
Open
Brain submissions: label zip downloads with the customer name#147rezakhadjavi wants to merge 1 commit into
rezakhadjavi wants to merge 1 commit into
Conversation
Single and bulk zip downloads were anonymous: the file was named brain-submission-<id>.zip and the folders inside were just section keys, so a downloaded zip had nothing tying it to the customer. - zip filename now leads with a customer-name slug - every file inside the zip sits under a top-level folder named after the customer it came from (bulk selections can span customers, so each file is foldered by its own submission's customer) - add getSubmissionNamesByIds / getSubmissionNameById db helpers - tighten the archiver stream so the response is attached before finalize() runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by Josh: on the Brain submissions dashboard, downloading the data comes back as a zip with nothing identifying the customer.
Cause: both download paths were anonymous.
brain-submission-<id>.zip, folders inside were just section keys (brand_context/,personas/...).sub-<id>/.Nothing surfaced the customer (workspace) name, so a saved zip looked blank/unlabelled.
Change:
<customer>-brain-submission-<id>.zip; bulk uses<customer>-brain-files.zipwhen all selected files are from one customer, dated name when multiple).submissionId -> namemap.getSubmissionNamesByIds/getSubmissionNameByIddb helpers.finalize()runs) to guard against an empty stream.Typechecks clean (
tsc --noEmit). No schema or data changes; download labelling only.Leaving the merge to a human.