runneth-classic install-config: fix missing cascade installs (critical) - #106
Merged
Merged
Conversation
Real test install showed runneth-classic installing standalone with none of
its declared upstream dependencies actually installing. Root cause: the
upstream_dependencies field is metadata only — the actual install mechanism
for cascading dependencies is action: use-case-install entries in post_install,
which performance-bundle uses but runneth-classic did not.
Added 11 use-case-install actions to post_install, ordered for correctness:
1. add-roles-permissions — security scoping before anything else writes
2. corpus-search — brain search layer the orchestrator needs
3. plan-mode — plan-before-build enforcement
4. self-iteration-loop — grading layer
5. team-member-memory — per-teammate profiles
6. health-alerts — production hygiene for the routines that come later
7. building-integrations — pairs with the integrations-intent captured in setup
8. integration-capabilities-library — companion to building-integrations
9. bootcamp — knowledge corpus the orchestrator's educate chain reads
10. performance-bundle — cascades to brand-audit + paid-strategy-audit +
creative-deep-dive + weekly-performance-deck. brand-audit specifically
is required because setup-runneth-classic Turn 8 hands off to it.
11. competitor-intel — weekly scan capability, routine stays opt-in
Then the existing skill-invoke setup-runneth-classic runs, then show-intro.
Bumped to v1.0.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR fixes
Critical bug:
runneth-classicwas declaring its upstream dependencies as metadata only and never actually triggering them to install.The
upstream_dependenciesfield ininstall-config.jsonis informational — it documents what the pack expects to be available, but it does NOT cause those use cases to install. The actual cascading-install mechanism isaction: "use-case-install"entries inpost_install, whichperformance-bundleuses butrunneth-classicdid not.Result of the bug: installing
runneth-classicproduced a workspace with only the pack's own files. Bootcamp didn't install,brand-auditdidn't install (which broke Turn 8 of setup that hands off to it),corpus-search/plan-mode/team-member-memory/ all the foundation use cases didn't install. The customer ended up with an orchestrator referencing files that weren't there.The fix
Mirror
performance-bundle's pattern. Add 11use-case-installactions topost_install, ordered for correctness:add-roles-permissions— security scoping before anything else writescorpus-search— brain search layer the orchestrator needsplan-mode— plan-before-build enforcementself-iteration-loop— grading layerteam-member-memory— per-teammate profileshealth-alerts— production hygiene for the routines that come laterbuilding-integrations— pairs with the integrations-intent captured in setupintegration-capabilities-library— companion to building-integrationsbootcamp— knowledge corpus the orchestrator'seducatechain readsperformance-bundle— cascades tobrand-audit+paid-strategy-audit+creative-deep-dive+weekly-performance-deck.brand-auditis specifically required becausesetup-runneth-classicTurn 8 hands off to it.competitor-intel— weekly scan capability, routine stays opt-in until configuredThen the existing
skill-invoke setup-runneth-classicruns (so all foundation use cases are available when setup needs them), thenshow-introcloses the install.Bumped to v1.0.2 with a changelog note explaining the fix.
Cumulative iteration progress
This is the fourth install-flow improvement layering on top of the original
runneth-classicpack after real test installs:install_notesfetch guidance for large skill filesFiles changed
Only
runneth-classic/install-config.json. 92 lines added (11 new post_install actions + 1 changelog entry), 2 lines changed (version bump).