Skip to content

Bump lms-ref to pick up ggplot_args_linter - #523

Merged
d-morrison merged 1 commit into
mainfrom
claude/bump-lms-ref
Nov 3, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/bump-lms-ref

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Moves lms-ref in lint-changed-lines.yaml to psc 1b31160 (psc#89), so the lint on changed lines flags aes() nested in ggplot() and data passed to ggplot() instead of piped.

One line changed; no content.


Generated by Claude Code

Moves lms-ref to psc 1b31160 (psc#89), so the lint on changed lines flags
aes() nested in ggplot() and data passed to ggplot() instead of piped.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9nm2UYhuLY1k6irzLP
@d-morrison d-morrison self-assigned this Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I checked the PR live just now. #523 is open, not a draft and not merged. Its head is still 2e75b3bb4f26cc64605f228e0ec04e6652febadf, the commit I reviewed, so the review still applies.

I'm not changing the verdict.

Verdict

Ready for merge, provided the lint-changed-lines CI job passes with the new pin. I couldn't confirm that the new lms-ref SHA exists, because the lms repo wasn't reachable from this job.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "2e75b3bb4f26cc64605f228e0ec04e6652febadf",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only changed path is the lms-ref pin in lint-changed-lines.yaml, a full 40-character SHA in the same format as the old one; its existence in the private lms repo could not be verified from this job.",
  "holistic_assessment": "A single-line dependency pin bump with narrow scope and no content changes; the lint-changed-lines CI job passing is the validation for the new ref."
}

Reviewed commit: 2e75b3b

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2024 (review) — run

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-11-03 21:18 UTC

@d-morrison
d-morrison merged commit fdfc469 into main Nov 3, 2026
38 checks passed
@d-morrison
d-morrison deleted the claude/bump-lms-ref branch November 3, 2026 21:17

Copy link
Copy Markdown
Contributor Author

Merged under Ezra's mwc (cmsg_014QLd5McmoUEgMPRiXeVnjSMc2HjrQ1gQkgWs8axE5kgn, 2026-11-03 21:13 UTC). Merge checker: fully clean on head 2e75b3b, annotations read. Cross-harness review waived: the agy and OpenCode Go quotas are exhausted.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants