Skip to content

ci: replace qwt references with pds and remove non-ASCII emoji - #46

Merged
d-morrison merged 1 commit into
mainfrom
ci/pds-workflow-qwt-emoji-32
Oct 5, 2026
Merged

d-morrison merged 1 commit into
mainfrom
ci/pds-workflow-qwt-emoji-32

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Requested by Ezra

Closes #32

Before: five workflow files named the repo qwt (the UCD-SERG template it came from) in comments, and two lines carried a rocket emoji (claude.yml:11 comment, publish.yml "Deploy" step name), which the lab's ASCII-in-source rule flags.

After: the comments say pds and the rocket is gone (rocket reaction in the comment, Deploy as the step name), following the same fix already merged in mds (Morrison-Lab/mds#55).

How: text replacement in .github/workflows/ only (5 files, 6 lines). Checked that no qwt or non-ASCII character remains in those files and that every workflow file still parses as YAML. No behavior change.

🤖 Generated with Claude Code

…#32)

Comment and step-name changes only; no workflow behavior changes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@d-morrison d-morrison self-assigned this Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


The PR matches issue #32's enumerated scope exactly (4 qwt references + 2 emoji instances across 5 files), and the claude.yml:11 rocket-emoji fix is included along with the claude.yml:63 text fix — both items the issue called out in that file. Nothing is missing and nothing extra was touched.

No prior @claude/review comments exist on this PR, so this is a first-pass review.

Review

This is a minimal, well-scoped documentation/comment fix: 6 lines changed across 5 workflow files, purely replacing qwt → pds in comments and removing two non-ASCII rocket emoji (one in a comment, one in a step name). No workflow logic, triggers, permissions, or steps change.

Verified directly against the PR-head commit (not the restored-from-default-branch copy on disk):

  • All 5 changed files still parse as valid YAML.
  • No qwt references remain anywhere under .github/workflows/ (checked PR-head content, all files, not just the changed ones).
  • No non-ASCII characters remain anywhere under .github/workflows/ (checked PR-head content, all files).
  • The diff matches issue Workflow comments still call this repo qwt; two emoji in workflow files #32's scope exactly — all four named qwt references and both named emoji occurrences are addressed, nothing extra touched.
  • Commit message follows the repo's convention (imperative summary, explanatory body, Co-Authored-By trailer) and the PR description accurately describes the change with no overstated or fabricated claims.
  • Per CLAUDE.md's own guidance on .github/workflows/, these are comment/text-only edits with no semantic diff to the publish/preview/review pipelines, so no CI-impact concerns.

No CLAUDE.md violations, no bugs, no hallucinated references, and no scope creep.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "ae1ed18b635829fa43612e8cf6f3b353550e5322",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Checked all five changed workflow files at PR head for leftover qwt mentions, stray non-ASCII bytes, and YAML parse errors; none were found, matching the PR's own stated verification.",
  "holistic_assessment": "Diff scope matches issue 32 precisely, workflow trigger and permission behavior is unchanged, and no build or publish pipeline files were touched beyond comment text."
}

Reviewed commit: ae1ed18

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3024 (review) — run

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://Morrison-Lab.github.io/pds/pr-preview/pr-46/

Built to branch gh-pages at 2026-10-01 13:16 PDT.
Preview will be ready when the GitHub Pages deployment is complete.

@d-morrison
d-morrison merged commit afabc63 into main Oct 5, 2026
17 checks passed
@d-morrison
d-morrison deleted the ci/pds-workflow-qwt-emoji-32 branch October 5, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow comments still call this repo qwt; two emoji in workflow files

1 participant