Repository navigation
Bump lms-ref to pick up ggplot_args_linter - #309
Merged
Merged
Conversation
Moves lms-ref to psc 1b31160 (psc#89), so the lint on changed lines flags aes() nested in ggplot() and data passed to ggplot() instead of piped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9nm2UYhuLY1k6irzLP
Contributor
|
Claude finished review — View run A live fetch of PR #309 just now shows it open, not a draft, and not merged. Its head is VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "a4b8f45e161f98ba09fb1cbc69c360d2f8ce862b",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The only change is the lms-ref pin in lint-changed-lines.yaml, still a full 40-character SHA; its existence in the lms repo could not be verified here.",
"holistic_assessment": "A one-line dependency pin bump with no scope creep, no content changes, and no build artifacts; the lint-changed-lines CI run on this PR validates the new ref."
}Reviewed commit: a4b8f45 |
Contributor
Contributor
2026-11-03 21:17 UTC |
Contributor
Author
|
Merged under Ezra's Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
lms-refinlint-changed-lines.yamlto psc1b31160(psc#89), so the lint on changed lines flagsaes()nested inggplot()and data passed toggplot()instead of piped.One line changed; no content.
Generated by Claude Code