Repository navigation
Add cancel-superseded caller - #51
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9ojH5gMAJaAFRMPitW
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the change adding cancellation of stale pull request CI runs.
No open issues 🎉
What changed in this PR
Adds a caller for the shared Morrison-Lab/gha workflow to cancel stale pull request CI runs.
Changes:
- Triggers cancellation on pull request updates (
synchronize) and closure. - Grants Actions write and pull request read permissions.
- Delegates cancellation to
cancel-superseded.yml@v3; non-PR runs remain outside its intended scope.
| File | Description |
|---|---|
.github/workflows/cancel-superseded.yml |
Adds the event triggers, permissions, and shared workflow caller for stale-run cancellation. |
Review effort: Balanced
|
Claude finished review — View run I fetched PR 51 just now. It is open, not a draft, and not merged. Its head is still I found nothing to fix, so I left out the VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "f854dbb3545c371fac4f66fc515d9291743bf821",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The new cancel-superseded.yml caller workflow matches the canonical example in Morrison-Lab/gha, with correct triggers, permissions and reusable workflow reference.",
"holistic_assessment": "A single-file addition with no prose, code or math changes, so regression risk and scope concerns are minimal; the v3 tag could not be checked locally."
}Reviewed commit: f854dbb |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ezra's standing rule (2026-11-02): "always cancel stale runs". On Ezra's decision (2026-11-03) to roll this out to every Morrison-Lab repo with PR CI, this adds a 17-line caller for
Morrison-Lab/gha'scancel-superseded.yml(gha#1400, gha#1401, onv3). On everysynchronizeandclosedof a pull request it cancels that PR's queued and running runs for any head other than the current one, and every earlier run of a closed PR. Runs not tied to a PR (push tomain) are not covered. Not exercised before merge: the first live run is this PR's own next push or close.Generated by Claude Code