Repository navigation
Check that workflow callers grant the permissions their reusable workflows need - #50
Merged
Merged
Conversation
…flows need Calls the gha check-caller-permissions workflow (v3). A caller job that omits a permission its callee's jobs request fails at startup with no log, as lds's preview cleanup did for a week (Morrison-Lab/lds#1468). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dmqa3hWsgjovnGyT7qANYK
|
Claude finished review — View run No issues found. Checked for bugs and CLAUDE.md compliance. The PR adds one caller workflow,
I didn't see the workflow in a live run; this comes from reading the diff and the VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "cc1016258878cd0a908fc1a9dc32391b41355b71",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The new caller workflow check-caller-permissions.yml grants contents: read, which matches the callee job's permissions, and relies on input defaults that exist in the gha reusable workflow.",
"holistic_assessment": "A single-file addition consistent with the other gha v3 callers in this repo, with sensible triggers, no scope creep, and no build-artifact or regression concerns."
}Reviewed commit: cc10162 |
|
Contributor
Author
🤖 Antigravity agent reportCross-harness review (Argon: Gemini 4 Argon (Medium) via Antigravity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a caller for the gha
check-caller-permissionsworkflow (v3). A job that calls a reusable workflow without granting the permissions the callee's jobs request fails at startup with no log, which stopped lds's preview cleanup for a week (Morrison-Lab/lds#1468).Run at the pinned refs, the check reports no missing grants in this repository today, so the PR adds only the guard.
Generated by Claude Code