Skip to content

Add cancel-superseded caller - #29

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-5vaqdp
Nov 5, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-5vaqdp

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Ezra's standing rule (2026-11-02): "always cancel stale runs". On Ezra's decision (2026-11-03) to roll this out to every Morrison-Lab repo with PR CI, this adds a 17-line caller for Morrison-Lab/gha's cancel-superseded.yml (gha#1400, gha#1401, on v3). On every synchronize and closed of a pull request it cancels that PR's queued and running runs for any head other than the current one, and every earlier run of a closed PR. Runs not tied to a PR (push to main) are not covered. Not exercised before merge: the first live run is this PR's own next push or close.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9ojH5gMAJaAFRMPitW
Copilot AI balanced review requested due to automatic review settings November 3, 2026 16:36
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Claude finished review — View run


I fetched PR 29 live just now. It is open, not a draft, not merged, and its head is c26092e8a60827545e2c63822711f0a484a33f34. That is the commit I reviewed, so the verdict stands.

Findings

None. The diff adds one workflow file, .github/workflows/cancel-superseded.yml. It matches the examples/cancel-superseded.yml template in Morrison-Lab/gha and uses the same @v3 pin as the repo's other callers. It has no prose or math, so the content, macro and line-break rules don't apply.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "c26092e8a60827545e2c63822711f0a484a33f34",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The new cancel-superseded.yml caller matches the gha example exactly: same triggers, the actions write and pull-requests read grants, and the @v3 pin used by sibling callers.",
  "holistic_assessment": "The change is scoped to a single new workflow with no content, math, or build-artifact changes, and it does not touch the publish or preview pipelines."
}

Reviewed commit: c26092e

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

💰 Cost: $0.1999 (review) — run

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the workflow change to cancel stale pull-request CI runs.

No open issues 🎉

What changed in this PR

Adds a caller to the shared Morrison-Lab workflow to cancel stale PR CI runs, while leaving runs not associated with a PR unaffected.

Changes:

  • Triggers cancellation when a pull request is synchronized or closed.
  • Calls Morrison-Lab/gha’s reusable workflow at v3 with Actions write and pull-request read permissions.
File Description
.github/​workflows/​cancel-superseded.yml Adds the event triggers, permissions, and shared cancellation workflow call.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.2
Preview removed because the pull request was closed.

2026-11-05 07:20 UTC

@d-morrison
d-morrison merged commit cb2b6e7 into main Nov 5, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants