Seed arb whitelist and planner forwarding; add BBQ mint fallback and node-fetch compatibility fix#154
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47e83f5bff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,3 @@ | |||
| [ | |||
| "B59tYSWnDNTDbTsDXvhmXghJXsyunPsXfYFr7KfXBqYn" | |||
There was a problem hiding this comment.
Seed whitelist using full market objects
The seeded whitelist.example.json format is incompatible with the arb runner: start.sh now copies this file to whitelist.json, but services/arb/index.js expects each entry to be an object with fields like inMint/outMint and later skips entries missing inMint (if (!m?.inMint) continue). With a string-only seed file, first-boot deployments will load a non-empty whitelist that yields zero scannable markets, so arb scanning/trading is effectively disabled instead of falling back to the built-in starter market.
Useful? React with 👍 / 👎.
Motivation
mork-coreto themork-appautonomous planner to enable coordinated planning across services.node-fetchimport compatibility for environments where the package exports a default vs callable function.Description
BBQ_MINTconstant and use it as a final fallback forcontrols.executionAuthority.mintAllowlistinmork-app/src/lib/core/appControl.tswhen no allowlist entries are available, and persist the state viapersistState().services/arb/build_whitelist.jsto handlenode-fetchexports reliably by assigningfetchfromnodeFetchornodeFetch.defaultso the script works in both ESM/CJS packaging scenarios.services/arb/whitelist.example.jsoncontaining the BBQ mint as a seed example for the arb whitelist.services/mork-core/src/server.tsto introduceMORK_APP_URL, implementforwardToAppPlanner()and call it fromplannerTick()to forward ticks (fire-and-forget) to the mork-app planner endpoint.start.shto seedARB_DIR/whitelist.jsonfromwhitelist.example.jsonat startup whenwhitelist.jsonis missing, and log the seeding action or a warning when neither file exists.Testing
Codex Task