Skip to content

remove mediabar focus steal when returning to home from home row item - #213

Open
jmawet wants to merge 1 commit into
Moonfin-Client:masterfrom
jmawet:return-to-home
Open

remove mediabar focus steal when returning to home from home row item#213
jmawet wants to merge 1 commit into
Moonfin-Client:masterfrom
jmawet:return-to-home

Conversation

@jmawet

@jmawet jmawet commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

When returning to home from another screen, there was additional code saying

if prevfocus = homerows
if mediabar enabled
focus media bar
else
focus home rows

which makes no sense, why would you want focus to go to media bar if you came from home rows?

so I deleted that bit and it now returns to home rows correctly if you left the home screen from a home row item (still goes back to media bar if you left home screen from media bar)

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • delete mediabar focus trap if previous focus was home row

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Go to home row, click on item
  2. Click back button, focus goes to the item you clicked in 1, no longer goes to media bar always

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Back key return to Media Bar instead of previous screen/position

1 participant