Skip to content

map navbar color between moonbase and roku - #212

Open
jmawet wants to merge 1 commit into
Moonfin-Client:masterfrom
jmawet:navbar-color-reset
Open

map navbar color between moonbase and roku#212
jmawet wants to merge 1 commit into
Moonfin-Client:masterfrom
jmawet:navbar-color-reset

Conversation

@jmawet

@jmawet jmawet commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Moonbase stores navbarColor as the color name (eg "slate"), whereas Roku needs the hex code (eg "0x475569")

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • create ColorMapping to map the color names to codes
  • change navbarColor setting sync conversion type to colorName
  • for conversion type colorName, use ColorMapping as LUT
  • add white/cyan/magenta color options

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Set navbarColor in moonbase
  2. Push to user
  3. Sidebar is no longer black on roku

Screenshots (if applicable)

This was directly after opening the app (post moonbase push):
image

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@jmawet
jmawet force-pushed the navbar-color-reset branch from b32ef23 to 0946a7a Compare August 9, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Moonfin Nav Bar turns transparent or black with pushed settings

1 participant