Skip to content

Preroll crash - #206

Merged
RadicalMuffinMan merged 2 commits into
Moonfin-Client:masterfrom
jmawet:preroll-crash
Aug 7, 2026
Merged

Preroll crash#206
RadicalMuffinMan merged 2 commits into
Moonfin-Client:masterfrom
jmawet:preroll-crash

Conversation

@jmawet

@jmawet jmawet commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Adds a safeguard in the queue manager to avoid crashes with wonky cinemamode settings sync

Adds a safeguard in settingsSync to ensure boolean values are written correctly to local settings

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • add toBoolean in queueManager to prevent type mismatch
  • add toBoolean in settingsSync to ensure bools written correctly moving forward

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Playback no longer crashes

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan
RadicalMuffinMan merged commit 45eb9ca into Moonfin-Client:master Aug 7, 2026
1 check passed
@jmawet
jmawet deleted the preroll-crash branch August 7, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Playback] App crashes when attempting playback

2 participants