Add server profile sync mappings for PR 217/218 fields and Implementations - #199
Conversation
…in user configuration on Moonbase pull
…ths, and show description on pause
|
do you wanna convert this to draft until it's ready? |
|
I updated it last night with the implementations :) Guess you missed the wall of text in our discord chat hey? haha |
|
These were already implemented:
These weren't implemented yet, but were added to the PR:
These have been removed:
|
Add UI setting toggle entries for Resume Rewind, Unpause Rewind, Skip Forward Length, Skip Back Length, Prefer SDH Subtitles, Prefer Audio Description, and Show Description on Pause.
Remove Show Description on Pause entry as requested.
|
You know what would have been helpful though? Some toggles 🤦 |
- Place Resume Rewind, Unpause Rewind, Skip Forward Length, and Skip Back Length under Video Playback Preferences. - Place Prefer Audio Description under Audio Preferences. - Place Prefer SDH Subtitles under Subtitle Preferences.
|
pending to implement: I believe none of these exist in roku currently |
|
Thanks for the list. Converting to draft while I look through them. |
…json Add settings.json definitions for: - showCastButton (navbar.show_cast) - collectionsRowShowEpisodes (ui.home.collectionsRowShowEpisodes) - playlistsRowShowEpisodes (ui.home.playlistsRowShowEpisodes) - classicHomeRowsPadding (ui.home.classicRowsPadding) - modernHomeRowsPadding (ui.home.modernRowsPadding) - recommendationSystemSource (ui.home.recommendationSource) - recommendationsApplyParentalRatingCap (ui.home.recommendationsParentalCap) - detailShowTechnicalDetails (ui.library.showTechnicalDetails) - musicPlaybackTimeDisplay (playback.musicTimeDisplay) - playbackTimeAboveLeft/Center/Right & playbackTimeBelowLeft/Center/Right (playback.timeAbove/Below...) - screensaverMode (screensaver.mode)
c301565 to
e8e2e5c
Compare
ccbdedc to
43dace9
Compare
these I would recommend leaving these out for now. I don't think you can cast from roku to other devices, and the playlist/collection individual rows are still having issues so the other 2 aren't useful yet screensaver/recommendation system I'm not sure are supported in roku? may not need these either playback time display, details buttons hide/order, home screen padding, seerrrows (for seerr tab I assume? different than home row?), showtechnicaldetails <- these should all be possible to implement. Not sure which you want to include in this pr or if it'd be better to do a pr for each of the features individually. Up to you |
ee2214f to
ea89d79
Compare
4943958 to
bc241f2
Compare
4dd537e to
bf6a07e
Compare
Pull Request
Summary
Add support for Moonbase settings sync parity on Roku, including syncing subtitle mode, subtitle language, default audio language, and audio preferences directly to Jellyfin User Configuration when pulling from Moonbase (PR #217 and PR #218).
Also includes some implementations of settings that were ready to sync for Smart-TV but weren't implemented in Roku yet.
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
GetMappings()in settingsSync.bs for playback time bar customization:musicPlaybackTimeDisplay(playback.musicTimeDisplay),playbackTimeAboveLeft/Center/Right(playback.timeAboveLeft/Center/Right),playbackTimeBelowLeft/Center/Right(playback.timeBelowLeft/Center/Right).collectionsRowShowEpisodes,playlistsRowShowEpisodes,mergeRecentRowsByType.detailButtonOrder(ui.itemdetail.buttonOrder),hiddenDetailButtons(ui.itemdetail.hiddenButtons),seerrRowOrder(seerr.rowOrder),hiddenSeerrRows(seerr.hiddenRows).showCastButton(navbar.show_cast),classicHomeRowsPadding,modernHomeRowsPadding,detailShowTechnicalDetails,recommendationSystemSource,recommendationsApplyParentalRatingCap,screensaverMode.subtitleMode,defaultSubtitleLanguage,defaultAudioLanguage, andpreferDefaultAudioTrack.m.global.session.user.ConfigurationinPullFromServer()whenever Moonbase pushes down new subtitle mode or language preferences.subtitleModeFormatconversion handlers between Moonbase strings (default,always,onlyforced,none) and Jellyfin user config enum values (Default,Always,OnlyForced,None).playback.resumeRewind) inLoadVideoContentTask.bswhen starting playback from a bookmark.playback.unpauseRewind) inVideoPlayerView.bswhen resuming from pause.playback.skipForwardLength,playback.skipBackLength) for LEFT/RIGHT remote key seeking inVideoPlayerView.bs.playback.showDescriptionOnPause) visibility control on the pause overlay inVideoPlayerView.bs.Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Include screenshots or recordings for UI changes.
Checklist