Repository navigation
fix(xbox): an account without an Xbox profile isn't kept; fresh in-app sign-in page; QR code on the TV - #125
Open
xservzeroman wants to merge 2 commits into
Open
xservzeroman wants to merge 2 commits into
xservzeroman wants to merge 2 commits into
Conversation
…e handheld signs in on a fresh in-app page Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd the private-window tip Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #124.
Saleh, test266: "after signing in with an email with no Xbox account you can't sign out to start fresh."
Root cause
Xbox.pollSignIn()saved the Microsoft tokens, then rantry { webAuth(ctx) } catch {}, which swallowed the XSTS refusal (401 with XErr 2148916233 for "no Xbox profile"). So the app ended "Signed in" with no gamertag. Sign out existed. But "Open the page" used the phone's browser, which was still logged in to that Microsoft account at microsoft.com/link, so the next sign-in went straight back to the same account.Fix (shared sign-in, so the handheld and the TV both get it)
signOut) andXbox.ProfileErrorcarries a plain message, e.g. "This Microsoft account has no Xbox profile. Sign in with the account you use on your Xbox."unverified. The handheld says Xbox network couldn't be reached.XboxSignInActivity. It openshttps://www.microsoft.com/link?otc=<code>in a WebView inside MoonCast, after clearing cookies and web storage every time, so no remembered account. It closes itself when the poll succeeds or the profile check fails, and Close returns to the code card.Xbox.signOut()clears those cookies too.microsoft.com/link?otc=<code>, generated on the device byQr.kt, a compact port of Project Nayuki's QR Code generator (MIT; added to Licences with its text);Testing
https://www.microsoft.com/link?otc=ABCD1234and a v9 multi-block one both decode correctly with zxing-cpp (EC level M).🤖 Generated with Claude Code