Skip to content

fix(xbox): a null DecodeInfo no longer closes the player #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xservzeroman wants to merge 1 commit into
base: release/1.0-beta3
Choose a base branch
from
Open

fix(xbox): a null DecodeInfo no longer closes the player #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## Unreleased
- **Xbox closed as soon as it connected (Odin, beta 3, Saleh):** libwebrtc hands MoonCast's low-latency H.264 decoder wrapper a null `DecodeInfo` with a frame; the Kotlin override declared it non-null, so the first frame threw (`NullPointerException … LowLatencyDecoder.decode, parameter info`) and the player closed. The parameter is nullable now and is passed on as is.

## 1.0-beta3 (2026-10-24)
- Beta 3: everything from test244 to test265 below (release-signed, version code 993). Power (Hibernate, Restart, Shut down) is in the Quick menu: Hibernate, Wake and resuming the game were confirmed on Windows by Saleh.
- **A stream that doesn't start now gives up with a reason (TV, test258):** a PC game sent to the TV 0.5 s after the sender left its own stream found the PC still holding that session; the TV's player waited in Moonlight's RTSP handshake for about 30 s with /status "starting" and no error. Now, if the stream hasn't started after 15 seconds, the player tries once more; if the second try hasn't started after 15 seconds either, it stops with "<PC> didn't start the stream. It may still be busy with another device; try again in a few seconds", which the sender reads from /status ("failed"). Handheld streams get the same one retry.
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/java/com/limelight/xbox/XboxDecoders.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ private class LowLatencyDecoder(private val delegate: VideoDecoder, private val
return delegate.initDecode(settings, callback)
}
override fun release(): VideoCodecStatus = delegate.release()
override fun decode(frame: EncodedImage, info: VideoDecoder.DecodeInfo): VideoCodecStatus = delegate.decode(frame, info)
// libwebrtc passes a null DecodeInfo (seen on the Odin 2 Portal's c2.qti.avc.decoder): a non-null Kotlin parameter
// threw on the first frame and the player closed as soon as the Xbox connected
override fun decode(frame: EncodedImage, info: VideoDecoder.DecodeInfo?): VideoCodecStatus = delegate.decode(frame, info)
override fun getImplementationName(): String = delegate.implementationName + "+mooncast-low-latency"

private fun patch() {
Expand Down