Repository navigation
fix(tv): keep BouncyCastle X25519 in release builds so identity transfer works - #107
Open
xservzeroman wants to merge 1 commit into
Open
xservzeroman wants to merge 1 commit into
xservzeroman wants to merge 1 commit into
Conversation
…fer works R8 removed org.bouncycastle.jcajce.provider.asymmetric.edec, which the provider loads by name, so a release-built TV answered /mc-native with an empty identityKey and could never receive an identity. Verified: 1.0-test258 (release signed, code 992) on the Google TV Streamer publishes its key, and an iPad sent Desktop on xserv Gaming to it with no pairing on the TV. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Release-built MoonCast TVs (1.0-beta2, for example) answered
/mc-nativewith an emptyidentityKey. So no phone or iPad could send them an identity, and a TV with no pairing of its own couldn't play PC games from them.Cause
R8 removed
org.bouncycastle.jcajce.provider.asymmetric.edec. The provider only loads those classes by name, so R8 saw them as unused. Debug builds aren't minified, so they were never affected.Fix
One keep rule in
app/proguard-rules.pro.Testing
edecclasses again.Stacked on #106.
🤖 Generated with Claude Code