[#49] Refactor/test entity classes to match with README file #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors several entity classes to ensure they accurately reflect the specifications outlined in the project's README file
Missed out a few lines in ApplicationIntegrationTest where it was not refactored and still using AnnotationTest1, AnnotationTest2, AnnotationTest3
Mom0aut
requested changes
Aug 29, 2025
Owner
Mom0aut
left a comment
Mom0aut
left a comment
There was a problem hiding this comment.
Thanks for your contribution 🚀
added the @Getter for the 3 refactored classes as well as adding the lombok plugin for the main project structure as the @requiredargsconstructor in RelationDaoFactory.java of the main project file could not intiliaze variable applicationContext in the default constructor
Mom0aut
requested changes
Aug 30, 2025
- Removed @Getter annotation from entity files , renamed and refactored DAO files
…to refactor/test-entity-classes-final
Removed lombok dependencies from all pom.xml, removed AnnotationTestRelation.java and AnnotationTestRelationDao.java, Renamed entity files from PersonDao > PersonEntityDao , DogDao > DogEntityDao, DocumentDao > DocumentEntityDao
updated Contributing.md to include a 'Set Up' section, where it shows the user specific things to check during the set up of the project.
…68898/DynamicRelations into refactor/test-entity-classes
Owner
|
Thanks for your work, if you resolve the last parts i can merge it into the master branch 😄 |
PersonEntityDao > PersonDao , DogEntityDao > DogDao, DocumentEntityDao > DocumentDao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refactored Entity Classes to match README.md example. The refactored classes was AnnotationTest1, AnnotationTest2, AnnotationTest3. They were refactored into PersonEntity, DogEntity, DocumentEntity respectively.
Issue ticket number and link
#49
Checklist before requesting a review