fix: write velocities or forces alone in restart files - #193
Open
galjos wants to merge 1 commit into
Open
Conversation
The PQ atom-line guard required both velocities and forces to be present before writing them, so a system carrying only one of the two was written as a bare 6-field position line. The supplied data was silently discarded and the resulting file could not be read back by RestartFileReader, which accepts only 12 or 21 fields. Writing whenever either quantity is present keeps the supplied values and pads the missing block with zeros.
Contributor
|
PYLINT REPORT Your code has been rated at 9.78/10 Full reportRaw metrics
Duplication
Messages by category
% errors / warnings by module
Messages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #193 +/- ##
=======================================
Coverage 93.94% 93.94%
=======================================
Files 177 177
Lines 9227 9227
=======================================
Hits 8668 8668
Misses 559 559
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard
frame.has_vel and frame.has_forcesdropped both blocks when only one was present, silently losing the data and producing lines the restart reader rejects. Changed toor; the missing block is padded with zeros.The added test round-trips vel-only and forces-only systems through write and read.
Fixes #192.