feat: Refactor exception handling to use a new templated base excepti… - #533
Open
97gamjak wants to merge 4 commits into
Open
feat: Refactor exception handling to use a new templated base excepti…#53397gamjak wants to merge 4 commits into
97gamjak wants to merge 4 commits into
Conversation
…on class - Introduced a new base exception class `BaseException` that utilizes template parameters for color and type, improving the handling of custom exceptions. - Updated existing tests to replace references to `customException` with the new `exc` namespace. - Modified exception throwing in various test files to align with the new exception handling structure. - Added new exception types to `exceptionTypes.hpp` for better categorization of errors. - Implemented colorful output for exception messages to enhance visibility in logs.
⚡ Performance (instruction count) — ✅ no regressionsper-benchmark breakdown
Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #533 +/- ##
==========================================
+ Coverage 91.33% 91.43% +0.10%
==========================================
Files 321 323 +2
Lines 14747 14660 -87
Branches 4943 4926 -17
==========================================
- Hits 13469 13405 -64
+ Misses 1193 1170 -23
Partials 85 85 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on class
BaseExceptionthat utilizes template parameters for color and type, improving the handling of custom exceptions.customExceptionwith the newexcnamespace.exceptionTypes.hppfor better categorization of errors.