Repository navigation
Make the mirror window follow the light/dark theme - #7
Merged
Merged
Conversation
The mirror window merged Themes/Dark.xaml into its own resources, so it was dark even with the app in light mode. It now uses the app's theme like every other window. Its own colors (stage, scrim, live/pending/alert dots, toolbar ink) move to Mirror* brushes in Light.xaml and Dark.xaml, and the spinner ring uses Track instead of a hardcoded dark color. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er ring in light - Checklist rows and the recording icon use resource references instead of FindResource copies, so a theme switch while the window is open updates them. - New MirrorRing brush for the connecting ring and pending dots (Track was nearly invisible on the light scrim). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The screen mirroring window was always dark, even with the app in light mode.
MirrorWindow.xamlmergedThemes/Dark.xamlinto its own resources. Now it follows the app theme like every other window, and switching the theme while it's open updates it too, because it usesDynamicResource.Mirror*brushes inThemes/Light.xamlandThemes/Dark.xaml: stage, scrim, live/pending/alert dots and toolbar ink. The dark values are unchanged.Trackinstead of a hardcoded dark color.Kept out of the website PR (#6) on purpose. This ships with the next app release.
How I tested it
dotnet build windows/Orbit.Windows: 0 errors. The 4 warnings were already there.dotnet test windows/Orbit.Tests: 44 passed.Checklist
dotnet test windows/Orbit.Testsandgradlew testDebugUnitTest lintDebugpass (Android untouched; CI runs both)docs/PROTOCOL.mdand unknown packets stay non-fatal (none)CHANGELOG.mdupdated (Unreleased section) if users will notice the change🤖 Generated with Claude Code