Repository navigation
test(cli): add published, kind and root_commit_id to the nightly receipt fixtures - #975
Merged
azimafroozeh merged 1 commit intoOct 13, 2026
Conversation
…y receipt fixtures
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The first scheduled run of
tests-slow-nightly.ymlwent red on threenightly:tests of the CLI crate that round-trip a fixture receipt through the client and compare the serialized result against the fixture JSON.CommitOutputgainedpublishedin feat: add unpublished graph commits #942 andkindplusroot_commit_idin feat(branching): add unattached graph branches #956; itsDeserializefills the three from defaults when a receipt lacks them and itsSerializealways writes them, so a fixture without them never round-trips equal.#[ignore]d nightly owners behind: no PR check runs them, so the drift surfaced on the nightly's first run (two reds before feat(branching): add unattached graph branches #956, three onmainsince)."published": true, "kind": "published", "root_commit_id": null, the values the deserializer derives for a plain published receipt:client::tests::managed_mutations_use_thirty_second_deadline_without_retrying,client::tests::managed_reads_use_thirty_second_deadline_without_retrying,managed::data::tests::managed_load_sends_exact_ndjson_and_preserves_the_server_receipt. No production change.Backing issue / RFC
tests-slow-nightly.ymlChecklist
CommitOutputserializes--run-ignored onlystep, not onTest WorkspaceLocal verification
cargo nextest run --workspace --exclude omnigraph-gqt --exclude omnigraph-gqt-served --exclude omnigraph-dst --locked --profile ci --no-fail-fast --run-ignored only --features omnigraph-engine/failpoints,omnigraph-cluster/failpoints -E '<the workflow's 16 enrolled names>'on0a7bb8c0before the fix: 13 passed, 3 failed, exit code 100, the three tests above, eachassertion left == right failedon the receiptscripts/check-workspace-test-owners.py target/nextest/ci/junit.xml --passed <the 16 names>:workspace owners OK (16 passed)cargo fmt --all --check,cargo clippy -p omnigraph-cli --all-targets --locked -- -D warnings -W clippy::dbg_macro: cleanPROPTEST_CASES=48: not run locally; the step and the engine crate are untouched by this changeNotes for reviewers
nightly:test changes only when its author remembers it, since no PR check runs it; the same drift recurs with the nextCommitOutputfield until the gate runs these tests under a settable deadline.