Repository navigation
fix(release): read a pre-0.14 stable release's HTTP contract from its source - #1125
Merged
ragnorc merged 1 commit intoOct 22, 2026
Merged
Conversation
… source The edge release text compared the build's HTTP contract with the latest stable release's, but v0.13.0 does not report its contract, so the text said only that it was not reported and never that the contract changed. The publisher now reads HTTP_API_CONTRACT from the stable tag's crates/omnigraph-api-types/src/lib.rs, and the composer uses it when the binary reports none; a binary that reports a contract must agree with its source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every edge release text compares the build with the latest stable release. v0.13.0's
omnigraph versionhas nohttp-contractline, so the current text foredge-20261020-7fd9cc9says:That hides the one thing a deployer needs: the contract changed (0.13 → 0.14, from #1074), so the CLI, the server and every HTTP integration have to be upgraded together.
How
crates/omnigraph-api-types/src/lib.rs, the step extracts that file.scripts/edge_release.py body --stable-source <file>readspub const HTTP_API_CONTRACT: &str = "…";from that file. It uses the value only when the stable binary reports no contract. A binary that does report one must agree with its source, and a file defining the constant twice is refused.v0.13.0's CLI (
client.rs) and server (http_contract.rs) both send and check this constant, so it is the contract that release speaks. From v0.14.0 on,omnigraph version --jsonreports the contract itself, and the source fallback only cross-checks it.Evidence
scripts/test_edge_release.py: 17 tests, 2 of them new. One covers the fallback, agreement, disagreement, a duplicate definition and an absent constant. The other runsbodyend to end with--stable-sourceand checks the refusal of--stable-sourcewithout--stable-tag.I ran the facts and compose logic locally against the real
v0.13.0tag and binary and the published0.14.0-edge+7fd9cc9binary. It renders:actionlint,
check-release-vocabulary-gates.py,check-workflow-action-pins.py,check-docs.py,check-agents-md.shand typos all pass.docs/dev/ci.mddocuments the fallback.