Log timeout-sweep arming at boot; read env in the packaged config - #20
Merged
Merged
Conversation
Production frontend showed zero sweep activity across days of 210s stalls while the identical build enforced budgets perfectly in local prod-topology tests - and nothing observable distinguished 'armed but never triggered' from 'never armed'. One error_log line at boot now states the effective max_execution_time and sweep interval, and a warning fires when the sweep resolves disabled. The packaged config also hardcoded max_execution_time=30 with no env read, so any app without a published octane config silently ignored OCTANE_MAX_EXECUTION_TIME - which is also why two local repros of the prod stall were invalid until caught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 210s-stall hunt needs one prod fact nothing currently logs: is the sweep armed, and at what value. One boot line now states it (plus a warning when disabled), and the packaged config's hardcoded max_execution_time=30 becomes an env read — apps without a published octane config were silently ignoring OCTANE_MAX_EXECUTION_TIME. Verified in the prod-topology e2e (8 workers + 2 task workers): arming line prints, 20s hang dies at 9.4s with a 408. Suite 190 green.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.