Skip to content

Sweep visibility: log and cancel over-budget requests whose client left #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhikjoshi merged 1 commit into from
Aug 21, 2026
Merged

Sweep visibility: log and cancel over-budget requests whose client left #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Swoole/Actions/EnsureRequestsDontExceedMaxExecutionTime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,22 @@ public function __invoke()
// Delete the timer entry first
$this->timerTable->del($coroutineId);

// Check if the connection still exists
$age = time() - $row['time'];

// Check if the connection still exists. Log this case too: a
// dead fd here means a downstream proxy already gave up on a
// request the worker is STILL burning - silence made a whole
// class of production stalls invisible (the 210s nginx 504s).
if ($this->server instanceof Server && ! $this->server->exists($row['fd'])) {
error_log("⏱️ Request timeout (client gone): Coroutine #{$coroutineId} ran {$age}s of {$this->maxExecutionTime}s budget on worker {$row['worker_pid']}; fd {$row['fd']} already closed");

$this->cancelCoroutine($coroutineId);

continue;
}

// Log the timeout
error_log("⏱️ Request timeout: Coroutine #{$coroutineId} exceeded {$this->maxExecutionTime}s max execution time");
error_log("⏱️ Request timeout: Coroutine #{$coroutineId} ran {$age}s, exceeded {$this->maxExecutionTime}s max execution time (worker {$row['worker_pid']}, fd {$row['fd']})");

$cancelled = $this->cancelCoroutine($coroutineId);

Expand Down
Loading