Skip to content

测试：拿住 copy helper 的句柄再读退出码（修 CI 上常挂的诊断测试） #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiyinxi merged 1 commit into from
Nov 6, 2026
Merged

测试：拿住 copy helper 的句柄再读退出码（修 CI 上常挂的诊断测试） #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/emu/crash_archive_windows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"path/filepath"
"strconv"
"strings"
"syscall"
"testing"
"time"

Expand Down Expand Up @@ -231,6 +232,14 @@ func TestDiagnosticCrashHelperSurvivesShortLauncher(t *testing.T) {
if helper.PID == 0 || !helper.Alive() {
t.Fatal("orphan did not survive launcher")
}
// The exit code outlives a process only while some handle to it is open (win.Process.ExitCode). The helper was
// found in the process table, so nothing in this test holds one: hold it here, or on a machine where nobody else
// does (the CI runner) its exit code is gone by the time it is read below.
held, err := syscall.OpenProcess(syscall.SYNCHRONIZE|syscall.PROCESS_QUERY_INFORMATION, false, helper.PID)
if err != nil {
t.Fatal("open copy helper", err)
}
t.Cleanup(func() { syscall.CloseHandle(held) })
t.Cleanup(func() { helper.Kill(); helper.Wait(time.Second) })
if _, err := os.Stat(m.crashScanPath(0)); !os.IsNotExist(err) {
t.Fatal("unfinished copy advanced watermark")
Expand Down
Loading