Repository navigation
问题包的隐私提示不再说「脚本不会上传」 - #87
Merged
Merged
Conversation
collect-info 的隐私提示是从 collect-info.ps1 逐字搬来的,第一句写着「脚本不会上传」。 ModAVD 0.38.2 起包里没有这个脚本了(ModAVD/ModAVD#119),收集问题信息由管理器和命令行做, 第一句改成「问题包只保存在本机,管理器和命令行都不会上传它。」,其余几条不变。 对拍测试的 golden 还是脚本的原样输出:summary.txt 和控制台里这一行按「modavd 有意写得不一样」处理, 其余逐字核对;另外断言提示里不再有「脚本」。 Refs ModAVD/ModAVD#45
This was referenced Nov 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
收集问题信息做完后显示、也写进
summary.txt开头的隐私提示,第一句还是「隐私提示:问题包只保存在本机,脚本不会上传。」。这句是从collect-info.ps1逐字搬来的。ModAVD 0.38.2 起包里没有这个脚本了(ModAVD/ModAVD#119),收集问题信息由管理器和命令行做,所以改成按实际情况说:其余几条(里面有什么、哪些能公开、crash 文件夹怎么发)一字不改。这是 #84 另审时记下的 P3(「已知没修的」第一条)。
改了什么
internal/report/report.go:PrivacyNote的第一行。testdata/golden还是脚本的原样输出,不改。parity_windows_test.go:summary.txt里的这一行,和 PowerShell 版本、adb 那两行一样,按「modavd 有意写得不一样」处理(modavdLine)。控制台输出核对时,除了第一行,其余照旧逐字核对。另外断言提示里不再有「脚本」。internal/cli/report_test.go:人读输出的结尾照旧和 golden 逐字比,只把第一行换成新的。测过什么
gofmt -l .没有输出;go vet ./...在 windows、darwin/arm64、linux/amd64 都过;Windows 上go test ./...全过。summary.txt不做这一行的替换;scripts/privacy.py0 失败。Refs ModAVD/ModAVD#45