Repository navigation
test(avd): create the production comparison at mas_1's resolution - #67
Merged
Merged
Conversation
TestMatchesProductionInstance builds an instance with the options read from D:\ModAVD's mas_1 and compares the bytes. Since ModAVD#61 new instances default to 1080p while mas_1 is 720p, so the test now passes mas_1's resolution like the other options. Only hw.lcd.width/height/density differed; nothing else in the template changed. Refs ModAVD/ModAVD#100
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61 合进 main 以后，
internal/avd的TestMatchesProductionInstance在维护者的机器上挂了（CI 上没有生产根目录，这个测试是跳过的，所以 CI 一直是绿的）。这个测试按生产根目录
mas_1的选项（内存、核数、数据盘、帧率）新建一台，再逐字节比config.ini和mas_1.ini。#61 把新建的默认分辨率改成了 1080p，而mas_1是 720p，测试没把它的分辨率传进去。挂的时候两边只差hw.lcd.width、hw.lcd.height、hw.lcd.density三行，模板别的地方一个字节都没变，所以是测试没跟上，不是 #61 改坏了。改法：和别的选项一样，把
mas_1的分辨率（in.Resolution()）也传给Create，注释里补一句原因。只改测试。验证：在有生产根目录的机器上跑
go test ./internal/avd -run TestMatchesProductionInstance（只读生产的两个配置文件）；不带这个改动时照样挂在那三行上。Refs ModAVD/ModAVD#100