Repository navigation
fix(web): home sections below the hero never stay hidden (E-065) + two doc facts - #4
Merged
Merged
Conversation
…s: Python ≥3.12, I1–I19 useReveal ran on every render; the backdrop's mount re-render disconnected the observer and cancelled the safety timer, leaving all 18 [data-reveal] sections at opacity 0 (measured live). Effect now runs once per mount, re-adopts hidden elements, reveals all on cleanup. Verified: production build in Chromium with the backdrop -> 0/18 hidden; vitest 34/34 (+2 that fail on the old hook). README layout line Python 3.13 -> >=3.12; AI_USAGE I1-I11 -> I1-I19.
MoTechSys
force-pushed
the
genspark_ai_developer
branch
from
October 6, 2026 19:27
dc2d82c to
bf790a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0 on the live home page: on capable devices (where the WebGL backdrop mounts ~1 s after load) every section below the hero stayed at opacity 0 — measured live: 18/18
[data-reveal]hidden after a full scroll (0/18 on a 2-core device where the backdrop is skipped). Cause:useRevealre-ran on every render; the backdrop re-render disconnected the observer and cancelled the safety timer, and the new run selected[data-reveal]:not([data-in])= nothing.Fix: effect runs once per mount, re-adopts already-hidden elements, reveals everything on cleanup.
Measured: production build in Chromium with the backdrop → 0/18 hidden; vitest 34/34 (+2 regression tests that fail on the old hook); tsc, oxlint 0 errors, build ok.
Docs: README layout line
Python 3.13→≥ 3.12(matches pyproject); AI_USAGEI1–I11→I1–I19(matches SAFETY). E-065 in DECISIONS, CHANGELOG Fixed.(The earlier bot health-dependency content of this PR is already on main via c39d9f1/2fb4b0e.)