Repository navigation
Modernize bindings for Mojo 1.2 - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated bindings still used Mojo 1.0 APIs and failed to compile under 1.2 for atomics. Require Mojo 1.2+ and lock development to 1.2.0, with current atomic, char, endian, and pointer APIs.
Validation:
pixi run check-lightpassed, including the commit hook.pixi run test: 338 passed, 8 existing skips.pixi run build: sdist and wheel built.Native runtime validation covers Linux x86-64. ARM/Linux and Apple char mapping have Clang target tests, not native variadic ABI acceptance. Dynamic varargs remain explicit stubs, and the private
_Globaldependency remains isolated in the process-lifetime cache adapter.