Skip to content

use biome#823

Draft
u1-liquid wants to merge 1 commit intomainfrom
use-biome
Draft

use biome#823
u1-liquid wants to merge 1 commit intomainfrom
use-biome

Conversation

@u1-liquid
Copy link
Member

@u1-liquid u1-liquid commented Nov 24, 2024

What

現在の動作確認:ビルド・backendの起動

テスト前に以下のコマンドを2回実行する必要がある

pnpm biome check --write --unsafe --diagnostic-level=error

frontendはsafe fix適用するとぶっ壊れるのでデバッグが必要

  • achivement.tsでaccount.tsの$iに対してReferenceErrorが発生する
    TDN関連の問題だと思うけどどこがどうなってこうなるのかまだつかめてない

Why

いい加減formatter入れたい・eslintが遅すぎる

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mattyatea
Copy link
Member

mattyatea commented Mar 14, 2025

ReferenceErrorはBiomeのorganizeImportsをオフにすればでなくなった
具体的には
frontend/src/boot/*
frontend/src/directives/index.ts
のimportの順番を直すと正常に動作することは確認してる

追記
最終的に main-boot.ts だけを修正すれば問題ないことが分かった。

フォーマットした後、
frontend/src/boot/main-boot.ts と frontend/src/boot/common.ts で

import { $i, signout, updateAccount } from '@/account.js';
import { instance } from '@/instance.js';

を最後にimportするようにしてあげると治る

@u1-liquid
Copy link
Member Author

よくよく考えたらそもそも$iをimportで持ってくること自体間違ってる設計かもしれない

@u1-liquid
Copy link
Member Author

biome 2.0 正式リリースされると適用する予定

@u1-liquid u1-liquid deleted the branch main May 12, 2025 13:38
@u1-liquid u1-liquid closed this May 12, 2025
@u1-liquid u1-liquid reopened this May 12, 2025
@snyk-io
Copy link

snyk-io bot commented May 12, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@u1-liquid u1-liquid changed the base branch from io_temp to main May 12, 2025 14:08
@coderabbitai
Copy link

coderabbitai bot commented Dec 14, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch use-biome

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedburaha@​0.0.1761007475100
Addedcacheable-lookup@​7.0.010010010082100
Addedcanvas-confetti@​1.9.410010010083100
Addedbroadcast-channel@​7.2.0991008984100
Addedbufferutil@​4.0.91001009284100
Addedcbor@​10.0.1110010010085100
Addedbullmq@​5.66.09610010096100

View full report

@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants