Skip to content

feat: add cancelandwithdraw()#19

Merged
g4titanx merged 4 commits intomasterfrom
feat/cancel-and-withdraw
Mar 19, 2026
Merged

feat: add cancelandwithdraw()#19
g4titanx merged 4 commits intomasterfrom
feat/cancel-and-withdraw

Conversation

@g4titanx
Copy link
Member

No description provided.

@ozwaldorf
Copy link
Member

can we remove the old methods or just call them as internal funcs so the bytecode isn't duplicated

@EmperorOrokuSaki
Copy link
Member

Agree with oz

@g4titanx
Copy link
Member Author

can we remove the old methods or just call them as internal funcs so the bytecode isn't duplicated

yeah removed withdraw(), keeping requestcancellation() though because

  • cancelAndWithdraw() reverts (BondActive) — can't withdraw mid-bond
  • requestCancellation() succeeds — sets the flag so no new node can bond after the current one expires/collects

Copy link
Member

@ozwaldorf ozwaldorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont merge until frontend pr is ready - breaking changes introduced

@g4titanx g4titanx merged commit ec41fdf into master Mar 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants