Feat/token metadata caching#46
Conversation
|
@K1NGD4VID Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Miracle656
left a comment
There was a problem hiding this comment.
Token metadata caching is the right approach for #37. Three things to address:
1. Remove scratch/generate_fixtures.js
Same as #45 — this debug script shouldn't be committed. git rm scratch/generate_fixtures.js.
2. Stacked on #45
Your diff includes all of #45's changes (decoder rename, decoder tests, fixtures). If #45 merges first your diff will shrink automatically to just the caching additions. Please either: (a) wait for #45 to merge and rebase, or (b) confirm you want this PR to supersede #45 and we'll close that one.
3. prisma/schema.prisma changes
You're adding to the Prisma schema here and also in #48. Make sure only one PR owns schema changes to avoid conflicts.
b0a2f1c to
7555083
Compare
|
I've addressed the feedback for both PR #37 (feat/token-metadata-caching) and PR #45 (test/xdr-decoder-unit-tests). Here’s the summary of the changes: Removed scratch/generate_fixtures.js: I've removed this script from the feat/token-metadata-caching branch. I also ensured it was cleaned up on the test/xdr-decoder-unit-tests branch as previously requested. feat/token-metadata-caching: Rebased on #45, script removed, force-pushed. |
Miracle656
left a comment
There was a problem hiding this comment.
Good progress — scratch/generate_fixtures.js is gone. The token metadata cache (memory → DB → RPC) is the right architecture.\n\nOne thing to fix before merging:\n\nRebase on main — PR #45 (XDR decoder) merged today, so your branch still carries all of #45's changes in the diff. After rebasing, the diff will shrink to just the caching-related additions (tokenCache.ts, tokenCache.test.ts, schema changes, etc.) making it much easier to review in isolation.\n\n\ngit fetch origin\ngit rebase origin/main\ngit push --force-with-lease\n\n\nOnce rebased I'll approve immediately.
Summary
Related issue
Type of change
Checklist
npx tsc --noEmitpassesnpm run buildpasses