Repository navigation
Conversation
…romised The section comment above /api/auth/keys says the routes 'require the admin scope' when auth is on; nothing enforced it — scopes were stored on every key and read nowhere. Any workspace-scoped key could mint itself a '*' key. Mint, list, revoke and delete now demand 'admin' or '*' in the calling key's scopes; anonymous dev mode is unchanged. (cherry picked from commit 41110d9) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Thanks for this. The escalation path is already closed on main: since 8b0e262 (2026-09-08) PermissionPlug requires the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The comment block above the key-management routes states: "When auth is on (auth_required: true) they require the
adminscope." Nothing enforces that —scopesis stored on every key and read nowhere in the request path (onlyworkspace_scopeis checked, by WorkspaceAuthPlug).Consequence: any authenticated key, however narrowly scoped, can
POST /api/auth/keysand mint itself a"*"key — least-privilege issuance is decoration.Change
POST/GET /api/auth/keys,POST .../revokeandDELETE .../:idnow require"admin"or"*"in the calling key's scopes → 403admin_scope_requiredotherwise. Anonymous dev mode (auth off) is unchanged, same as every other route.Regression tests included (read-scoped key: 403 on all four; wildcard key: 201).
🤖 Generated with Claude Code