Repository navigation
Add local browser mode and verified installation paths - #67
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MinorGlitch
changed the base branch from
dev/recovery-state-cleanup
to
master
October 22, 2026 15:01
Keep font objects and glyph subsets local to each PDF. Verify every bundled font embeds correctly and invalid selected fonts never fall back to core fonts. All 204 pages in the template matrix render identically; representative PDF groups run 20-24% faster.
Retain separate platform runs, file-level scheduling, full test selection and coverage gates. Use logical CPU counts capped at four so hosted Linux and Windows runners can use four workers and macOS can use three. The same 532-test local sample improves from 208s to 139s with lazy font loading.
Build the UI and recovery-worker test pages once through esbuild's API. Run at most two browser engines concurrently using the existing Node test runner, retaining both kit variants and every recovery/scanner check per engine. Wait for siblings and close browsers before removing shared files. Remove the unused subprocess build helper. Local Chromium/WebKit check: 95.78s -> 64.10s (33% faster). Validation: 311 Node tests, Chromium/Firefox/WebKit browser checks, kit lint and format. A deliberately unavailable WebKit still reports failure while Chromium completes and shared fixtures are cleaned up.
Traverse Button instances directly instead of evaluating a CSS selector against every widget after each interaction. Preserve all message, refresh, animation, resize and button-feedback synchronization. Cover nested button subclasses and hidden controls retaining their active class. Python 3.14 with coverage and four workers: 204.37s -> 193.57s (5% faster), with all 394 original tests plus one regression test and 24 subtests passing. The profiled readiness check performed the same 254 scans, taking 0.169s instead of 2.925s. Platform jobs and coverage gates are unchanged.
Use pytest-split with recorded timings to distribute every UI test exactly once per platform. Require coverage from both Linux groups before applying the existing gates; preserve all assertions and synchronization behavior.
Let Homebrew request its Linux and macOS runners before native builds consume the remaining hosted-runner capacity. Preserve every platform, UI group, packaging lifecycle check, and coverage gate.
MinorGlitch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can install, upgrade, and remove Ethernity using verified release artifacts, and optionally run the existing terminal app in a local browser with
ethernity --web. The terminal remains the default. This PR also improves recovery text entry and reduces CI time while retaining the platform tests and coverage gates.Validation: CI run 40085452016 passed all 33 jobs on implementation commit
d69b09da494c63f7cd5a2a5cf32d89faf8bc497b. This includes Linux, macOS, Windows, both UI groups on each platform, end-to-end recovery, visual checks, both recovery kit variants in Chromium and WebKit, dependency audits, native packages, the Python distribution, and both Homebrew platforms. Application coverage is 88% against the 85% gate; inspector coverage is 49% against 45%.Installer checks cover installation, failed upgrades, rollback, replacement, recovery, and uninstall. Homebrew also upgrades a real installed
0.0.1fixture to the release bottle and checks obsolete-command removal. That fixture exercises the upgrade mechanism; format compatibility remains covered separately. The final repository change only corrects the documented test-group count from three to four.PyPI account and trusted-publisher setup remains pending at the owner's request. WinGet community submission requires public release assets. Merging this PR does not publish a release.