fix: correctly read cache metadata as UTF-8#203
Merged
stephantul merged 1 commit intoJun 18, 2026
Conversation
Confidence Score: 5/5Safe to merge — one-line change with a targeted regression test that correctly exercises the exact failure mode. The change is minimal: a single No files require special attention. Reviews (1): Last reviewed commit: "修复 Windows 缓存元数据编码读取" | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata.jsonwith explicit UTF-8 encoding during cache validationRoot cause
SembleIndex.save()writes cache metadata as UTF-8 JSON bytes, butget_validated_cache()read the same file using the platform default text encoding. On Windows systems using CP936/GBK, UTF-8 metadata containing non-ASCII file paths could fail during cache validation before the cached index was loaded.Fixes #202
Validation
uv run --extra dev pytest tests/test_cache.pyuv run --extra dev ruff check src/semble/cache.py tests/test_cache.pyuv run --extra dev --extra mcp pytest -k "not test_walk_files_skips_symlinks"docs\\测试检查清单.mdwithPYTHONUTF8andPYTHONIOENCODINGunsetNote: full
uv run --extra dev --extra mcp pytestreaches 271 passed and then fails only ontests/test_file_walker.py::test_walk_files_skips_symlinksbecause this Windows environment lacks permission to create symlinks (WinError 1314).