chore(issue-feed): remove deprecated backward-compat inputs#29
Conversation
All 8 callers have been migrated to @main and no longer pass issue_labels or project_group_id. Remove the deprecated optional inputs and their associated no-op blocks. Verified: grep for issue_labels, project_group_id, ISSUE_LABELS, PROJECT_GROUP_ID, labels_part, proj_gid, require_group_id all return empty in the resulting file.
Jerry-Xin
left a comment
There was a problem hiding this comment.
Summary: Relevant, narrowly scoped cleanup of the .github reusable issue-feed workflow with no blocking issues found.
💬 Non-blocking
🟡 Warning — .github/workflows/octo-issue-feed.yml: Removing workflow_call inputs is breaking for any caller that still passes issue_labels or project_group_id. This checkout has no local octo-issue-feed callers to verify, so merge safety depends on the external caller audit in the PR description. Given that all known callers are reported migrated, this is not blocking.
✅ Highlights
🔵 Suggestion — The change is a pure schema cleanup: only deprecated ignored inputs were removed, with no runtime notification logic changed.
✅ Verified locally: YAML parses successfully, actionlint passes for octo-issue-feed.yml, and no issue_labels, PROJECT_GROUP_ID, labels_part, proj_gid, proj_msg, or require_group_id references remain in this workflow.
lml2468
left a comment
There was a problem hiding this comment.
Summary
Removes the deprecated issue_labels and project_group_id inputs from octo-issue-feed.yml that were kept for backward compatibility in PR #28.
Findings
None. Verified all 8 downstream callers have already been updated:
| Repo | issue_labels |
project_group_id |
|---|---|---|
| octo-server | ✅ removed | ✅ removed |
| octo-web | ✅ removed | ✅ removed |
| octo-adapters | ✅ removed | ✅ removed |
| octo-deployment | ✅ removed | ✅ removed |
| octo-matter | ✅ removed | ✅ removed |
| octo-smart-summary | ✅ removed | ✅ removed |
| octo-admin | ✅ removed | ✅ removed |
| octo-lib | ✅ removed | ✅ removed |
The deprecation cycle is complete: PR #28 added the no-ops → callers cleaned up → this PR removes the no-ops. Textbook backward-compatible deprecation.
Verdict
APPROVED — safe to merge, all callers confirmed clean. (Submitted as COMMENTED due to GitHub limitation.)
Summary
Removes
issue_labelsandproject_group_iddeprecated inputs fromocto-issue-feed.ymlreusable workflow.Pre-conditions verified
@mainwithout passing these inputs ✅What changed
Pure deletion — 14 lines removed, zero lines added:
issue_labels+project_group_idinput declarationsVerification checklist
issue_labelsremoved ✅project_group_idremoved ✅Next steps after merge
v2tag pointing at this commit@main→@v2