fix: support stdin-backed file options on Windows - #208
Merged
NianJiuZst merged 1 commit intoAug 21, 2026
Conversation
NianJiuZst
reviewed
Aug 21, 2026
NianJiuZst
left a comment
Collaborator
There was a problem hiding this comment.
No blocking findings on the current head. Replacing the POSIX-only /dev/stdin path with file descriptor 0 preserves the documented --*-file - interface and makes it work on Windows, so I recommend merging it.
Verified against current main: focused test, a real piped text chat --messages-file - --dry-run probe, typecheck, and lint (one pre-existing warning). #208 and #229 also pass the combined full suite (402/402).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix cross-platform support for documented
-stdin inputs:/dev/stdinpath with file descriptor0mmx text chat --messages-file -through the shared helper--text-file -and--lyrics-file -working through the same helper on Windows, macOS, and LinuxRoot cause
The shared reader and text-chat command hard-coded
/dev/stdin, which does not exist on Windows.Tests
0.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.